Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apprise Support 📡 #1971

Merged
merged 25 commits into from
Aug 1, 2023
Merged

Apprise Support 📡 #1971

merged 25 commits into from
Aug 1, 2023

Conversation

jeankhawand
Copy link
Contributor

@jeankhawand jeankhawand commented Jul 8, 2023 •
edited
Loading

created 2 webhooks and added them to services url field separeated by comma and that's the result below:
image

Next step

  • format message
  • enhance process for push entires
  • try it with matrix and telegram and maybe remove current integration? not sure will check with maintainers

Do you follow the guidelines?

@jeankhawand
🎉 Initial Notion Support
4c1496f 
➕ http patch with json
➕ http custom headers
@jeankhawand
Merge remote-tracking branch 'origin' into feature/notion-support
2d2025b
@jeankhawand
➕ default us l11n for notion form field
51791ec 
🔨 fix integration order
@jeankhawand
✍️ fix typo
3ea17e3
@jeankhawand
✍️ migration typo
8be6cc8
@jeankhawand
✍️ typo again!!
3354351
@jeankhawand
🔃 replace http with https in placeholder
4f2ab56 
➕ add notion form labels in French
@jeankhawand
➕ add missing translations keys for other locales
7af1759 
✍️ get rid of notionURL cause it's not changing for the time being
@jeankhawand
✍️ combine resource with endpoint url
ef6e6a7
@jeankhawand
✍️ fix new client params
41fbf1e
@jeankhawand
add license lines
4a430c6
@jeankhawand
remove unnecessary trailing newline (whitespace)
8a7a7a3
@jeankhawand
🎉 support apprise to push entries/entry via different messaging services
097cb8d 
➕ add apprise service container to dev container
✍️ update locale
➕ check if apprise host in reachable
@jeankhawand
Merge remote-tracking branch 'origin' into feature/apprise-support
1bf0e2c
@jeankhawand
➕ placeholder text for apprise url
48fc672
@jeankhawand
😃fix conflicts
a756ef4
@jeankhawand
Copy link
Contributor Author

jeankhawand commented Jul 9, 2023 •
edited
Loading

Matrix integration:
image
Telegram integration:
image

will stick with markdown format to show entries alongside their urls

@jeankhawand
Copy link
Contributor Author

jeankhawand commented Jul 9, 2023 •
edited
Loading

Takeaway

  • Might encounter some API rate limit especially for Discord I do get 429 error. I did reach out to Apprise maintainer – will consider to handle the limit using a retry mechanism (Discord Rate Limiting (429 Error code) handling caronc/apprise#901)
  • As of now it's working as expected on Matrix and Telegram didn't have time to try other integrations. Normally it should work if a certain service doesn't offer markdown support it will be default to text
    CC @fguillot

@jeankhawand
Copy link
Contributor Author

jeankhawand commented Jul 9, 2023 •
edited
Loading

closes #1970 #1490 #1611 #1607 #1034

@jeankhawand jeankhawand changed the title Feature/apprise support Apprise Support 📡 Jul 10, 2023
@jeankhawand
Copy link
Contributor Author

Hello @fguillot , please consider reviewing it. I am unable to request reviewer.
Thanks

This was linked to issues Aug 1, 2023
Centralise pushing entries to third parties via apprise #1970
Closed
Apprise integration #1490
Closed
Request： Support Gotify or Apprise #1611
Closed
Support webhooks for generic notifications #1607
Closed
Add Webhooks for events #1034
Closed
@fguillot fguillot merged commit bf4823b into miniflux:main Aug 1, 2023
14 checks passed
This was referenced Aug 22, 2023
Closed
Closed
@fguillot fguillot removed a link to an issue Sep 9, 2023
Add Webhooks for events #1034
Closed
1 task
@vincejv vincejv mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fguillot fguillot Awaiting requested review from fguillot

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@jeankhawand @fguillot